Add option to save single mapped counts by side #248
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agalitsyna
reviewed
Sep 6, 2024
| ) | ||
| if self.single_mapped_by_side: | ||
| left_only_mapped_count = np.logical_and( | ||
| df_filtered["chrom1"] != unmapped_chrom, |
There was a problem hiding this comment.
Hmmm, this definition of "one-sided mapped" won't work for chimeric reads originating from R1. It will count them as "two-sided" although they factually come from R1 oly. This looks like a re-implementation of single-end mapped pairs.
There was a problem hiding this comment.
Ummm is there a way to account for those properly at all at this stage? I think without some extra arguments this information is just lost...
There was a problem hiding this comment.
Yeah, you need walk_pair_type column for that
https://pairtools.readthedocs.io/en/latest/parsing.html#rescuing-complex-walks section walk_pair_types
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.