[Bugfix]/Use default values for SIMILARITY and NUM_LINES for the Azure CosmosDB datastore provider-405#406
Open
adgrajales1 wants to merge 2 commits intoopenai:mainfrom
Open
Conversation
visridha
reviewed
Jan 22, 2024
Goo78
approved these changes
May 31, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Short Description: This PR fixes an issue where it's not possible to use the Azure CosmosDB datastore provider because it needs some default values for both similarity and num lines. Those values are provided as environment variables and have some default values in the code (in case the environment variables are not provided)
The issue is described here: #405