-
-
Notifications
You must be signed in to change notification settings - Fork 21
Feature/redoc documentation #113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/redoc documentation #113
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you ok to change it to https://app.quartz.energy/QUARTZENERGY_LOGO_TEXTONLY_WHITE.svg
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here is the current screenshot. I changed to the logo to the one you requested, but it's all white so it's barely visible:
This is a screenshot with the old logo:
/swagger does not bring up swagger docs. Do you still want it to?
Also, for future reference, should I comment on the issue or message you once I've submitted a pull request?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, please, /swagger is useful too
perhaps, could you trim the "quartz solar" to just "quartz"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One small change needed on the logo
Also, could you add a screen shot of /docs
Also, does /swagger still bring up swagger docs?
Thanks for this, ill merge on to a |
Yep, it should be ready to merge. |
Thnka you @Edwardcg17 for this |
Thanks @Edwardcg17 , @all-contributors please add @Edwardcg17 for code |
I've put up a pull request to add @Edwardcg17! 🎉 |
Pull Request
Description
custom_openapi
to load a custom schemaFixes #112
How Has This Been Tested?
Starting the FastAPI server, then going to http://localhost:8000/docs. The page will be working documentation in Redoc style.
If your changes affect data processing, have you plotted any changes? i.e. have you done a quick sanity check?
Checklist: