Skip to content

Conversation

Edwardcg17
Copy link
Contributor

Pull Request

Description

Fixes #112

How Has This Been Tested?

Starting the FastAPI server, then going to http://localhost:8000/docs. The page will be working documentation in Redoc style.

  • [✔] Yes

If your changes affect data processing, have you plotted any changes? i.e. have you done a quick sanity check?

  • N/A

Checklist:

  • [✔] My code follows OCF's coding style guidelines
  • [✔] I have performed a self-review of my own code
  • [✔] I have made corresponding changes to the documentation
  • [✔] I have added tests that prove my fix is effective or that my feature works
  • [✔] I have checked my code and corrected any misspellings

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here is the current screenshot. I changed to the logo to the one you requested, but it's all white so it's barely visible:

image

This is a screenshot with the old logo:
image

/swagger does not bring up swagger docs. Do you still want it to?
Also, for future reference, should I comment on the issue or message you once I've submitted a pull request?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, please, /swagger is useful too

perhaps, could you trim the "quartz solar" to just "quartz"

Copy link
Contributor

@peterdudfield peterdudfield left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small change needed on the logo

Also, could you add a screen shot of /docs

Also, does /swagger still bring up swagger docs?

@peterdudfield peterdudfield mentioned this pull request Apr 6, 2025
@Edwardcg17
Copy link
Contributor Author

Shortened the logo and created the "/swagger" endpoint for swagger documentation. Screenshots:

Swagger:
image

Redoc:
image

@peterdudfield
Copy link
Contributor

Thanks for this, ill merge on to a development branch just to check its working. If thats ok? ready to merge?

@Edwardcg17
Copy link
Contributor Author

Yep, it should be ready to merge.

@peterdudfield peterdudfield merged commit d45999e into openclimatefix:main Apr 11, 2025
4 checks passed
@peterdudfield
Copy link
Contributor

Thnka you @Edwardcg17 for this

@peterdudfield
Copy link
Contributor

Thanks @Edwardcg17 ,

@all-contributors please add @Edwardcg17 for code

Copy link
Contributor

@peterdudfield

I've put up a pull request to add @Edwardcg17! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add redoc docs
2 participants