Skip to content

select the correct region #82

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Sep 24, 2024
Merged

select the correct region #82

merged 4 commits into from
Sep 24, 2024

Conversation

peterdudfield
Copy link
Contributor

@peterdudfield peterdudfield commented Sep 23, 2024 •
edited
Loading

Pull Request

Description

make sure we load the correct region

#81

How Has This Been Tested?

CI tests,

  • Yes

Checklist:

  • My code follows OCF's coding style guidelines
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked my code and corrected any misspellings

Sukh-P
Sukh-P reviewed Sep 24, 2024
View reviewed changes
Sukh-P
Sukh-P approved these changes Sep 24, 2024
View reviewed changes
Copy link
Member

@Sukh-P Sukh-P left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice catch!

@peterdudfield peterdudfield merged commit 783c1d3 into main Sep 24, 2024
8 checks passed
@peterdudfield peterdudfield deleted the issue/load-correct-region branch September 24, 2024 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sukh-P Sukh-P Sukh-P approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@peterdudfield @Sukh-P