Testing neater #350
Open
Testing neater #350
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sukh-P
reviewed
Sep 22, 2025
Comment on lines
138
to
139
| config = load_yaml_configuration(test_config_filename) | ||
| nwp_name, _ = next(iter(config.input_data.nwp.root.items())) |
There was a problem hiding this comment.
Could use the new _load_config_and_provider function here
Sukh-P
reviewed
Sep 22, 2025
| return cfg, provider | ||
|
|
||
|
|
||
| def _revalidate(cfg): |
There was a problem hiding this comment.
I know it's a small thing but config is clearer than cfg IMO as a parameter name, don't think the few characters saved in abbreviation outweigh the slight less clarity
There was a problem hiding this comment.
Also not sure about the function name, not super clear to me
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Neatening tests - subdirectory per commit for clarity (or thereabouts)
Current focus of removing redundancies, repetitions, reduction of line count etc - and also ensuring fixtures are present in conftest
Feel conftest should be segregated after this - will raise as issue