feat(backends): Swap to std python grpc lib#274
Merged
Conversation
devsjc
changed the title
devsjc
force-pushed
the
devsjc/python-grpc
branch
17 times, most recently
from
cade8a5 to
ce346a9
Compare
devsjc
force-pushed
the
devsjc/python-grpc
branch
from
dc543cf to
ba47979
Compare
devsjc
force-pushed
the
devsjc/python-grpc
branch
2 times, most recently
from
00f49ca to
818176e
Compare
devsjc
force-pushed
the
devsjc/python-grpc
branch
from
818176e to
ed90d3b
Compare
devsjc
force-pushed
the
devsjc/python-grpc
branch
from
ed90d3b to
928764a
Compare
| # assert len(data) == 11 | ||
|
|
||
|
|
||
| # 6.2 check status routes |
Contributor
There was a problem hiding this comment.
where did these tests go?
Contributor
Author
There was a problem hiding this comment.
Into a new file in the uk_national folder!
Contributor
peterdudfield
left a comment
peterdudfield
left a comment
There was a problem hiding this comment.
Ive left a few comments.
And it looks like we want to run it on dev for a few days, to make sure
- there are no errors
- the memory and cpu are ok
Contributor
|
Looks like there are some errors at the moment 
|
devsjc
force-pushed
the
devsjc/python-grpc
branch
from
e61dafc to
9fd488b
Compare
Contributor
Author
|
More stats from APItally showing a decreased memory useage: 
|
peterdudfield
approved these changes
Apr 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Modifies the GRPC client to use the default python GRPC library.
This is built on C, and doesn't do the same Serde setup of betterproto so should be much lighter on memory. As such, we shouldn't need the sync client any more.
I've also modified the tests such that most of the functionality is tested in unit tests, rather than integration tests. This is faster and cleaner.
Testing in development showed a much flatter memory profile and no significant change to CPU. In the below graphs, anything before the 14:30 in the middle was the old library, and afterwards, the new one: