-
-
Notifications
You must be signed in to change notification settings - Fork 8
add sentry function #9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: aryan lamba <aryanlamba54@gmail.com>
@peterdudfield can you take a look |
What do you want to discuss? About this issue? |
may be if i get issue so for that |
@peterdudfield have a look i thank at this time all are good . |
Not currently. Please ask on the relevant discussion in https://github.com/orgs/openclimatefix/discussions/categories/project-ideas-2025 |
@peterdudfield have a look |
ee89c4a
to
0b26b0c
Compare
Signed-off-by: aryan lamba <aryanlamba54@gmail.com>
@devsjc have a look |
@peterdudfield Is our sentry environment "production" regardless of where the code is deployed? Or should that be an environment variable? |
It should be an env var |
@devsjc I update the environment so can you look at this |
@peterdudfield I think now all things are done that you told me, so look at this ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is good, but ill get @devsjc to double check it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine to me, just want @devsjc to check
Hi @devsjc , Just following up on my PR. Could you please review it when you get a chance? Let me know if any changes are needed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please look at files changes, and you'll see some obvious mistakes
20deca4
to
7171873
Compare
I don’t see an issue, but for better clarity and performance, I optimized the code. |
sentry_sdk.set_tag("app_name", "satellite_consumer") | ||
sentry_sdk.set_tag("version", __version__) | ||
|
||
def _consume_command(command_opts: ArchiveCommandOptions | ConsumeCommandOptions) -> None: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you reset all changes below this, if you want to do this, please put in a different PR and explain what they are for and why
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if there is green lines below here, then it means new lines have been added
912d12b
to
fd8b9fe
Compare
eb8ab2f
to
fd8b9fe
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
see comments. Only add sentry code, dont add any other changes please
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lines 46 to 53 are good (and the import statement).
All other changes should be removed
Pull Request
Description
This PR adds Sentry integration to the satellite-consumer project. The integration helps in error tracking and performance monitoring by capturing exceptions and logs throughout the data processing pipeline.
Fixes #5
How Has This Been Tested?
⇾ Verified that errors are properly captured in Sentry by intentionally triggering an exception.
⇾ Ran the full data processing pipeline to ensure no breaking changes were introduced.
⇾ Logged relevant metadata (satellite name, time window, etc.) in Sentry for better debugging.
If your changes affect data processing, have you plotted any changes? i.e. have you done a quick sanity check?
Checklist: