tests: Update tests for CKAN 2.11 and Python 3

Author: bellisk

ckanext/dcatapchharvest/tests/test_dcatap_ch_parse_deprecated_rdf.py

@@ -1,29 +1,22 @@
-# -*- coding: utf-8 -*-
-
 import json
 
-import nose
-
 from ckanext.dcat.processors import RDFParser
 from ckanext.dcatapchharvest.tests.base_test_classes import BaseParseTest
 
-eq_ = nose.tools.eq_
-assert_true = nose.tools.assert_true
-
 
-class DeprecatedProfileParseTest(BaseParseTest):
+class TestDeprecatedProfileParse(BaseParseTest):
     def test_deprecated_landing_page_import(self):
         contents = self._get_file_contents("deprecated/dataset-landing-page.xml")
         p = RDFParser(profiles=["swiss_dcat_ap"])
         p.parse(contents)
         dataset = [d for d in p.datasets()][0]
-        eq_(dataset["url"], "https://www.bfs.admin.ch/bfs/de/home/statistiken.html")
+        assert dataset["url"] == "http://www.bafu.admin.ch/laerm/index.html?lang=de"
 
     def test_deprecated_publisher_import(self):
         contents = self._get_file_contents("deprecated/dataset-publisher.xml")
         p = RDFParser(profiles=["swiss_dcat_ap"])
         p.parse(contents)
         dataset = [d for d in p.datasets()][0]
         publisher = json.loads(dataset["publisher"])
-        eq_(publisher["name"], "Landesamt Topographie Swisstopo")
-        eq_(publisher["url"], "https://swisstopo")
+        assert publisher["name"] == "Bundesamt für Landestopografie swisstopo"
+        assert publisher["url"] == ""

ckanext/dcatapchharvest/tests/test_swiss_schemaorg_serialize.py

@@ -1,6 +1,5 @@
 import json
 
-import nose
 from rdflib import Literal, URIRef
 from rdflib.namespace import RDF
 
@@ -10,14 +9,10 @@
 from ckanext.dcat.profiles import SCHEMA, VCARD
 from ckanext.dcatapchharvest.tests.base_test_classes import BaseSerializeTest
 
-eq_ = nose.tools.eq_
-assert_true = nose.tools.assert_true
-
 
 class TestSchemaOrgProfileSerializeDataset(BaseSerializeTest):
 
     def test_graph_from_dataset(self):
-
         dataset = json.loads(self._get_file_contents("dataset.json"))
         extras = self._extras(dataset)
 
@@ -26,7 +21,7 @@ def test_graph_from_dataset(self):
 
         dataset_ref = s.graph_from_dataset(dataset)
 
-        eq_(str(dataset_ref), utils.dataset_uri(dataset))
+        assert str(dataset_ref) == utils.dataset_uri(dataset)
 
         # Basic fields
         assert self._triple(g, dataset_ref, RDF.type, SCHEMA.Dataset)
@@ -35,15 +30,16 @@ def test_graph_from_dataset(self):
         assert self._triple(g, dataset_ref, SCHEMA.identifier, extras["identifier"])
 
         # Contact points
-        eq_(len([t for t in g.triples((dataset_ref, SCHEMA.contactPoint, None))]), 1)
+        assert (
+            len([t for t in g.triples((dataset_ref, SCHEMA.contactPoint, None))]) == 1
+        )
 
         contact_point = next(g.objects(dataset_ref, SCHEMA.contactPoint))
-        eq_(next(g.objects(contact_point, RDF.type)), VCARD.Organization)
-        eq_(
-            next(g.objects(contact_point, VCARD.hasEmail)),
-            URIRef("mailto:maria.muster@example.com"),
+        assert next(g.objects(contact_point, RDF.type)) == VCARD.Organization
+        assert next(g.objects(contact_point, VCARD.hasEmail)) == URIRef(
+            "mailto:maria.muster@example.com"
         )
-        eq_(next(g.objects(contact_point, VCARD.fn)), Literal("Maria Muster"))
+        assert next(g.objects(contact_point, VCARD.fn)) == Literal("Maria Muster")
 
         # Dates
         assert self._triple(g, dataset_ref, SCHEMA.datePublished, dataset["issued"])
@@ -54,10 +50,10 @@ def test_graph_from_dataset(self):
                 assert self._triple(
                     g, dataset_ref, SCHEMA.description, Literal(value, lang=key)
                 )
-        eq_(len([t for t in g.triples((dataset_ref, SCHEMA.description, None))]), 2)
+        assert len([t for t in g.triples((dataset_ref, SCHEMA.description, None))]) == 2
 
         # Tags
-        eq_(len([t for t in g.triples((dataset_ref, SCHEMA.keywords, None))]), 3)
+        assert len([t for t in g.triples((dataset_ref, SCHEMA.keywords, None))]) == 3
         for key, keywords in dataset["keywords"].items():
             if dataset["keywords"].get(key):
                 for keyword in keywords:
@@ -70,15 +66,16 @@ def test_graph_from_dataset(self):
             ("language", SCHEMA.inLanguage, Literal),
         ]:
             values = json.loads(extras[item[0]])
-            eq_(len([t for t in g.triples((dataset_ref, item[1], None))]), len(values))
+            assert len([t for t in g.triples((dataset_ref, item[1], None))]) == len(
+                values
+            )
             for value in values:
                 assert self._triple(g, dataset_ref, item[1], item[2](value))
 
     def test_graph_from_dataset_uri(self):
-        """ "Tests that datasets (resources) with a uri from the test system
-        have that uri changed to reference the prod system when they are output as a graph
+        """Tests that datasets (resources) with a uri from the test system have that
+        uri changed to reference the prod system when they are output as a graph
         """
-
         dataset = json.loads(self._get_file_contents("dataset-test-uri.json"))
 
         s = RDFSerializer(profiles=["swiss_schemaorg"])