Skip to content

Fix/export distribution issued and modified dates #108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 6, 2024
Merged

Fix/export distribution issued and modified dates #108

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
bceeaee
docs: Fix copy/paste error in README
bellisk Aug 6, 2024
76e9896
fix: Add back issued and modified dates to Distribution graph
bellisk Aug 6, 2024
63f0b2e
tests: Test serialization of resource issued and modified
bellisk Aug 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ To install ckanext-dcatapchharvest for development, activate your CKAN virtualen
do:

git clone https://github.com/ogdch/ckanext-dcatapchharvest.git
cd ckanext-switzerland
cd ckanext-dcatapchharvest
python setup.py develop
pip install -r dev-requirements.txt
pip install -r requirements.txt
Expand Down
2 changes: 2 additions & 0 deletions ckanext/dcatapchharvest/profiles.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1027,6 +1027,8 @@ def graph_from_dataset(self, dataset_dict, dataset_ref): # noqa
('issued', DCT.issued, None, Literal),
('modified', DCT.modified, None, Literal),
]
self._add_date_triples_from_dict(resource_dict, distribution,
items)

# ByteSize
if resource_dict.get('byte_size'):
Expand Down
4 changes: 3 additions & 1 deletion ckanext/dcatapchharvest/tests/fixtures/dataset.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,7 +123,9 @@
],
"rights": "Creative Commons Zero 1.0 Universell (CC0 1.0)",
"license": "NonCommercialAllowed-CommercialAllowed-ReferenceNotRequired",
"format": "CSV"
"format": "CSV",
"issued": "2015-06-26T15:21:09.034694",
"modified": "2015-06-30T15:21:09.000000"
},
{
"id": "28e75e40-e1a1-497b-a1b9-8c1834d60201",
Expand Down
5 changes: 5 additions & 0 deletions ckanext/dcatapchharvest/tests/test_dcatap_ch_serialize.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -161,6 +161,11 @@ def test_graph_from_dataset(self):
expected_literal = Literal("P1D", datatype=XSD.duration)
assert self._triple(g, distribution, DCAT.temporalResolution, expected_literal)

if resource_dict.get('issued'):
assert self._triple(g, distribution, DCT.issued, resource_dict["issued"], XSD.dateTime)

if resource_dict.get('modified'):
assert self._triple(g, distribution, DCT.modified, resource_dict["modified"], XSD.dateTime)

def test_graph_from_dataset_uri(self):
"""Tests that datasets (resources) with a uri from the test system
Expand Down