Tests/update tests for ckan 2.11 python 3 #117
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For each language in the multilang dict, we might get a string or a list of values, e.g. {'de': 'Dataset Title'} or {'de': ['tag1', 'tag2', 'tag3']}. If it's a string, we need to wrap it in a list so we can safely iterate over it in the next line - otherwise we iterate by letter: 'D', 'a', 't', ...
Checking whether the value had the '__iter__' attribute worked for this in Python 2, but in Python 3, strings apparently also have this attribute. Let's just check whether the value is a list or not. If there are any other cases, we can catch them later!
bellisk
commented
Jul 31, 2025
| # the values can be either a multilang-dict or they are | ||
| # nested in another iterable (e.g. keywords) | ||
| if not hasattr(values, "__iter__"): | ||
| if not isinstance(values, list): |
There was a problem hiding this comment.
Apparently in Python 3, strings also have the __iter__ attribute. We need to really check whether the value is a list, not check for this attribute, or we won't correctly wrap a string value in a list (in the next line) and we'll end up iterating over it letter by letter.
I think there aren't any other kinds of iterable that we could get as a value here, only a list or a string, so this should be enough of a check here.
Let's get flake8 to look at everything else and fix these in a next step.
bellisk
commented
Jul 31, 2025
bellisk
commented
Jul 31, 2025
stefina
approved these changes
Jul 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.