Skip to content

Commit ca47ad0

Browse files
author
Hofstetter Benjamin
committed
useSeoMeta does not work with SSR
Fixes #25
1 parent a064da4 commit ca47ad0

File tree

2 files changed

+8
-21
lines changed

2 files changed

+8
-21
lines changed

opendata.swiss/ui/pages/datasets/[datasetId]/distribution/[distributionId].vue

Lines changed: 5 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -19,8 +19,8 @@ const { locale, t } = useI18n();
1919
2020
const route = useRoute()
2121
const router = useRouter()
22-
const datasetId = computed(() => route.params.datasetId as string)
23-
const distributionId = computed(() => route.params.distributionId as string)
22+
const datasetId = route.params.datasetId as string
23+
const distributionId = route.params.distributionId as string
2424
2525
2626
const { useResource } = useDatasetsSearch()
@@ -40,7 +40,7 @@ const distribution = computed(() => {
4040
if (!dataset.value) {
4141
return undefined
4242
}
43-
const dists = dataset.value.distributions.find(d => d.id === distributionId.value) ?? undefined
43+
const dists = dataset.value.distributions.find(d => d.id === distributionId) ?? undefined
4444
return dists
4545
})
4646
@@ -55,23 +55,16 @@ const breadcrumbs = [
5555
title: resultEnhanced.value?.getTitle,
5656
path: {
5757
name: 'datasets-datasetId',
58-
params: { datasetId: datasetId.value },
58+
params: { datasetId: datasetId },
5959
},
6060
},
6161
{
6262
title: distribution.value?.title
6363
}
6464
]
6565
66-
const seoTitle = computed(() => {
67-
if (distribution.value?.title) {
68-
return `${distribution.value.title} | ${t('message.dataset_detail.distribution')} | opendata.swiss`
69-
}
70-
return ` ${t('message.dataset_detail.distribution')} | opendata.swiss`
71-
})
72-
7366
useSeoMeta({
74-
title: seoTitle,
67+
title: () => `${distribution.value?.title} | ${t('message.dataset_detail.distribution')} | opendata.swiss`,
7568
})
7669
7770
await suspense()

opendata.swiss/ui/pages/datasets/[datasetId]/index.vue

Lines changed: 3 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ import { useSeoMeta } from 'nuxt/app';
2222
const { locale, t } = useI18n();
2323
const route = useRoute()
2424
const router = useRouter()
25-
const datasetId = computed(() => route.params.datasetId as string)
25+
const datasetId = route.params.datasetId as string
2626
2727
const { useResource } = useDatasetsSearch()
2828
const { query, isSuccess, resultEnhanced } = useResource(datasetId)
@@ -66,22 +66,16 @@ const breadcrumbs = computed(() => {
6666
title: resultEnhanced.value?.getTitle,
6767
path: {
6868
name: 'datasets-datasetId',
69-
params: { datasetId: datasetId.value },
69+
params: { datasetId: datasetId },
7070
},
7171
})
7272
7373
return result
7474
})
7575
76-
const seoTitle = computed(() => {
77-
if (dataset.value?.title) {
78-
return `${dataset.value.title} | ${t('message.header.navigation.datasets')} | opendata.swiss`
79-
}
80-
return `opendata.swiss | ${t('message.header.navigation.datasets')}`
81-
})
8276
8377
useSeoMeta({
84-
title: seoTitle,
78+
title: () => `${dataset.value?.title} | ${t('message.header.navigation.datasets')} | opendata.swiss`
8579
})
8680
8781

0 commit comments

Comments
 (0)