Skip to content

Conversation

BenjaminHofstetter
Copy link
Collaborator

Use ExternalLink Component in MDC Markdown Renderer.

  • detect internal or external links
  • render external links with the icon and target="_blank"
  • render internal links as <a ...

I am not sure if we should render them with NuxtLinks

Copy link
Collaborator

@tpluscode tpluscode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you sure this will not negatively affect links in blog/handbook/showcases? All those are markdown and will contain may links

Copy link
Collaborator

@tpluscode tpluscode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, I do have some suggestions

@BenjaminHofstetter
Copy link
Collaborator Author

Actually NuxtLinkLocale doesn't work with External Links.

@BenjaminHofstetter BenjaminHofstetter merged commit fe40935 into main Sep 11, 2025
1 check passed
@BenjaminHofstetter BenjaminHofstetter deleted the dataset-detail-markdown branch September 11, 2025 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants