Skip to content

Conversation

tpluscode
Copy link
Collaborator

No description provided.

@@ -44,9 +44,15 @@
<template #option="option">
<span>
{{ option.title }}
<span style="float: right; color: #888;">({{ option.count }})</span>
<span v-if="option.count" style="float: right; color: #888;">({{ option.count }})</span>
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hiding the ({count}) text when it's not set to avoid empty ()

#selected-option="option"
>
{{ option.title }}
<input type="hidden" :name="name" :value="option.id">
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hidden input makes it possible to use the component in native <form>

@@ -89,7 +89,7 @@ function isChildPage({ to }: OdsNavTabItem) {
<NuxtLinkLocale :class="{ active: isChildPage(item) }" :to="item.to"><span> {{ t(item.label) }}</span></NuxtLinkLocale>
</li>
<li v-if="item.subMenu" class="tab">
<v-menu>
<v-menu open-on-hover>
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made the menu to expand on hover so that Showcases in the menu is still a link but it also has child items in a submenu

@@ -0,0 +1,150 @@
<template>
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is direct copy from swiss design

@@ -0,0 +1,49 @@
<template>
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a copy from swiss design example plus...

Comment on lines +32 to +48
.notification-banner {
display: block;
transition-property: padding, opacity;
transition-timing-function: ease-in-out, ease-in-out;
}
.notification-banner:not([open]) {
padding: 0;
opacity: 0;
overflow: hidden;
}
.notification-banner__wrapper {
transition-property: height;
transition-duration: 0s;
}
.notification-banner:not([open]) .notification-banner__wrapper {
height: 0;
}
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

...a transition which smoothly collapses the notification when open is set from true to false

@@ -0,0 +1,109 @@
<template>
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also a copy from swiss design

}, (resource, localeInstance) => {
return {
...resource,
pref_label: resource.pref_label[localeInstance.currentLocale],
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I could not figure out a way to use the Extended result so that translations are automatically selected

@@ -37,6 +40,11 @@ export default defineNuxtConfig({
}
}
},
runtimeConfig: {
public: {
contentRoot: path.resolve(__dirname, 'content')
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will be used only locally to find the content dir in the repository.

@tpluscode tpluscode self-assigned this Sep 9, 2025
feat(showcase): select and upload showcase cover image
# Conflicts:
#	opendata.swiss/ui/nuxt.config.ts
Copy link

Your preview environment is deployed! 🚀
URL: https://showcase-form.piveau-ln-preview.zazukoians.org/
Note: It may take a few minutes for the DNS to propagate, the certificate to be generated and the preview to be reachable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant