Skip to content

Conversation

BenjaminHofstetter
Copy link
Collaborator

No description provided.

Copy link

github-actions bot commented Sep 17, 2025

Your preview environment is deployed! 🚀
URL: https://distribution-page.piveau-ln-preview.zazukoians.org/
Note: It may take a few minutes for the DNS to propagate, the certificate to be generated and the preview to be reachable.

@@ -0,0 +1,2 @@
export const PIVEAU_HUB_SEARCH_URL = 'https://piveau-hub-search-ln.zazukoians.org/';
export const PIVEAU_HUB_REPO_URL = 'https://piveau-hub-repo-ln.zazukoians.org/';
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is needed for metadata download. We should overrid them with environment variables in docker later.

@@ -54,30 +73,35 @@ const breadcrumbs = computed(() => {
return result
})


useSeoMeta({
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't work with SSR. It shows undefined in the browser tab.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I never noticed. Strange. If anything, this should work in SSR 🤔

@BenjaminHofstetter BenjaminHofstetter marked this pull request as ready for review September 17, 2025 09:37
Copy link
Collaborator

@tpluscode tpluscode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

too big to review thoroughly but lgtm

@@ -48,3 +48,9 @@ const props = defineProps<Props>()


</script>

<style scoped lang="scss">
.strech-card {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not part of swiss design then?

If you find this style useful, maybe put it in OdsCard?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no :-) it was part of OdsCard and we had probelms with the huge cards in e.g. https://piveau-ln.zazukoians.org/de/showcases.

This .strech-card is used to have equal heights in a "Grid".

@BenjaminHofstetter BenjaminHofstetter merged commit fcc5c23 into main Sep 18, 2025
2 checks passed
@BenjaminHofstetter BenjaminHofstetter deleted the distribution_page branch September 18, 2025 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants