-
Notifications
You must be signed in to change notification settings - Fork 0
Distribution page #22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Your preview environment is deployed! 🚀 |
@@ -0,0 +1,2 @@ | |||
export const PIVEAU_HUB_SEARCH_URL = 'https://piveau-hub-search-ln.zazukoians.org/'; | |||
export const PIVEAU_HUB_REPO_URL = 'https://piveau-hub-repo-ln.zazukoians.org/'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is needed for metadata download. We should overrid them with environment variables in docker later.
@@ -54,30 +73,35 @@ const breadcrumbs = computed(() => { | |||
return result | |||
}) | |||
|
|||
|
|||
useSeoMeta({ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This doesn't work with SSR. It shows undefined in the browser tab.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I never noticed. Strange. If anything, this should work in SSR 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
too big to review thoroughly but lgtm
@@ -48,3 +48,9 @@ const props = defineProps<Props>() | |||
|
|||
|
|||
</script> | |||
|
|||
<style scoped lang="scss"> | |||
.strech-card { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not part of swiss design then?
If you find this style useful, maybe put it in OdsCard
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no :-) it was part of OdsCard and we had probelms with the huge cards in e.g. https://piveau-ln.zazukoians.org/de/showcases.
This .strech-card is used to have equal heights in a "Grid".
No description provided.