tests: suppress winding warnings #1768
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #1768 +/- ##
========================================
Coverage 85.69% 85.69%
========================================
Files 149 149
Lines 16133 16133
========================================
Hits 13825 13825
Misses 2308 2308 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
I'm not sure if there is anything we can do to fix this warning, but having the warning in our output does not improve the situation, so ignore it for now.
Some datasets used in testing are wound clockwise, so ignore the winding warning in these tests.
pjonsson
force-pushed
the
fix-winding-warnings
branch
from
11a52c0 to
dcd3b21
Compare
|
Added this PR to the whats_new.rst update in #1769. |
SpacemanPaul
approved these changes
Apr 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for this pull request
Filter the clockwise winding warning from all tests that import the data sets with that issue.
Also ignore the numpy ndarray size warning until someone has time to look at the problem.
Refs #1716
Proposed changes
Closes #xxxx
Tests added / passed
Fully documented, including
docs/about/whats_new.rstfor all changes📚 Documentation preview 📚: https://datacube-core--1768.org.readthedocs.build/en/1768/