Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for this pull request
Tweak how STAC links are provided/determined, and include Sat and Sar extension links in stac_extensions when present.
Also take the opportunity to add a test for s1_nrb data.
Proposed changes
Rename
stac_url
tobase_url
for better clarity, as the url is not expected to include/stac
Remove
collection_url
param as it seems to be unnecessaryDon't use dataset uri to determine self and odc_yaml links, and warn if self link cannot be determined
Bring back
dataset_location
parameter from the original eo-datasets implementation, but rename toasset_location
to be more accurate to its usageCloses #xxxx
Tests added / passed
Pull Request Title will make sense in ODC Release Notes
📚 Documentation preview 📚: https://opendatacube--2156.org.readthedocs.build/en/2156/