storage: rework function for MyPy #2158
Merged
+18
−17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #2158 +/- ##
========================================
Coverage 86.39% 86.40%
========================================
Files 151 151
Lines 16382 16379 -3
========================================
- Hits 14153 14152 -1
+ Misses 2229 2227 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Ariana-B
reviewed
Sep 3, 2025
This function yields, so use Generator.
Check basis first and return early, and then do the other things. This makes it clear to MyPy that the measurements are the right type. This required a trickle of updated type signatures elsewhere, so follow that through.
pjonsson
force-pushed
the
testutils-type-fixes
branch
from
8b02b97 to
2f812f9
Compare
Ariana-B
approved these changes
Sep 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for this pull request
Check basis first and return early,
and then do the other things. This
makes it clear to MyPy that
the measurements are the right type.
This required a trickle of updated type
signatures elsewhere, so follow
that through.
Proposed changes
Closes #xxxx
Tests added / passed
Pull Request Title will make sense in ODC Release Notes
📚 Documentation preview 📚: https://opendatacube--2158.org.readthedocs.build/en/2158/