Skip to content

Commit f6ddc14

Browse files
omadpjonsson
authored andcommitted
Add note about strange store.close() function
1 parent e9e0998 commit f6ddc14

File tree

1 file changed

+6
-1
lines changed

1 file changed

+6
-1
lines changed

cubedash/summary/_stores.py

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -328,7 +328,12 @@ def create(
328328
)
329329

330330
def close(self) -> None: # do we still need this?
331-
"""Close any pooled/open connections. Necessary before forking."""
331+
"""Close any pooled/open connections. Necessary before forking.
332+
333+
Also useful during testing.
334+
"""
335+
# This is going to do the same .dispose() twice, but, it's a noop the second time
336+
# and will be safer until we can tidy up handling of the SQLAlchemy connections
332337
self.index.close()
333338
self.e_index.engine.dispose()
334339

0 commit comments

Comments
 (0)