Skip to content

Conversation

pindge
Copy link
Contributor

@pindge pindge commented Jun 7, 2022

fix #305 and #387

Scope:

  • Add a test product and datasets with regions
  • add assertion test to check product selection menu date displaying only date with datasets
  • add product region date selector filter for the selected region
  • add region summary years count for non-annual product

@codecov
Copy link

codecov bot commented Jun 7, 2022

Codecov Report

❌ Patch coverage is 97.72727% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 86.54%. Comparing base (1af8c56) to head (64eaae1).
⚠️ Report is 565 commits behind head on develop.

Files with missing lines Patch % Lines
cubedash/summary/_stores.py 97.22% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #388      +/-   ##
===========================================
+ Coverage    86.41%   86.54%   +0.12%     
===========================================
  Files           25       25              
  Lines         3121     3158      +37     
===========================================
+ Hits          2697     2733      +36     
- Misses         424      425       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@pindge
Copy link
Contributor Author

pindge commented Jun 14, 2022

needing some help from sqlalchemy sqlalchemy/sqlalchemy#8131

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add timeline plot to region view in Explorer
1 participant