Skip to content

Conversation

pjonsson
Copy link
Contributor

@pjonsson pjonsson commented Mar 23, 2025

@pjonsson pjonsson force-pushed the ci-fix-tests branch 2 times, most recently from c22bc12 to 28e9cd6 Compare March 23, 2025 11:32
Disable failing tests with a FIXME
so they are easy to find at a later
stage.
@pjonsson
Copy link
Contributor Author

pjonsson commented Mar 23, 2025

There are 3 tests still failing that I couldn't get to work. I suggest merging this so the CI becomes green, and then someone who knows more about explorer and its testsuite can take a look at it.

Edit: a log of the failures can be found in https://github.com/opendatacube/datacube-explorer/actions/runs/14019751866/job/39250105214.

Why do the tests print a million lines of == Index Call == get_dataset: 1.4252662658691406 on stderr?

Copy link

codecov bot commented Mar 23, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.27%. Comparing base (aa0d9f3) to head (218b0ea).
Report is 215 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #648      +/-   ##
===========================================
+ Coverage    86.29%   89.27%   +2.98%     
===========================================
  Files           26       34       +8     
  Lines         3451     4122     +671     
===========================================
+ Hits          2978     3680     +702     
+ Misses         473      442      -31     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Member

@omad omad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Peter!!!

@omad omad merged commit 9a84216 into opendatacube:develop Mar 23, 2025
7 checks passed
@pjonsson pjonsson deleted the ci-fix-tests branch March 24, 2025 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants