Add override annotations#668
Merged
Ariana-B merged 3 commits intoApr 14, 2025
Merged
Conversation
This will enable MyPy to flag methods that no longer override their base class method when refactoring the base class.
Copy the datacube-core mypy configuration from pyproject.toml and remove the config from setup.cfg. This aligns the mypy configuration with most other active datacube projects.
pjonsson
force-pushed
the
add-override-annotations
branch
from
fe91326 to
06f50be
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #668 +/- ##
===========================================
+ Coverage 89.26% 89.55% +0.28%
===========================================
Files 34 34
Lines 4119 4211 +92
===========================================
+ Hits 3677 3771 +94
+ Misses 442 440 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Ariana-B
approved these changes
Apr 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will enable MyPy to flag
methods that no longer override
their base class method when
refactoring the base class.
📚 Documentation preview 📚: https://datacube-explorer--668.org.readthedocs.build/en/668/