Skip to content

Conversation

pjonsson
Copy link
Contributor

@pjonsson pjonsson commented Apr 20, 2025

Import names from the module where
they are defined instead of some
module where they are imported.


📚 Documentation preview 📚: https://datacube-explorer--671.org.readthedocs.build/en/671/

@pjonsson pjonsson force-pushed the import-from-export branch 3 times, most recently from 0e223ba to 2b76c67 Compare April 20, 2025 23:50
Copy link

codecov bot commented Apr 21, 2025

Codecov Report

Attention: Patch coverage is 66.66667% with 2 lines in your changes missing coverage. Please review.

Project coverage is 89.56%. Comparing base (7d933f4) to head (4695b5b).
Report is 55 commits behind head on develop.

Files with missing lines Patch % Lines
cubedash/_pages.py 50.00% 1 Missing ⚠️
cubedash/_utils.py 66.66% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #671      +/-   ##
===========================================
+ Coverage    89.26%   89.56%   +0.29%     
===========================================
  Files           34       34              
  Lines         4119     4218      +99     
===========================================
+ Hits          3677     3778     +101     
+ Misses         442      440       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@pjonsson pjonsson force-pushed the import-from-export branch from 2b76c67 to aefc1c4 Compare April 22, 2025 20:38
@pjonsson pjonsson requested a review from omad April 22, 2025 20:40
Import names from the module where
they are defined instead of some
module where they are imported.
@pjonsson pjonsson force-pushed the import-from-export branch from aefc1c4 to 4695b5b Compare April 23, 2025 08:57
Copy link
Member

@omad omad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@omad omad merged commit eb321d4 into opendatacube:develop Apr 24, 2025
7 checks passed
@pjonsson pjonsson deleted the import-from-export branch April 24, 2025 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants