Skip to content

Conversation

pjonsson
Copy link
Contributor

@pjonsson pjonsson commented Apr 20, 2025

This file is never executed, so
remove the hashbang.


📚 Documentation preview 📚: https://datacube-explorer--672.org.readthedocs.build/en/672/

Copy link

codecov bot commented Apr 20, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.56%. Comparing base (7d933f4) to head (69b23de).
Report is 55 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #672      +/-   ##
===========================================
+ Coverage    89.26%   89.56%   +0.29%     
===========================================
  Files           34       34              
  Lines         4119     4217      +98     
===========================================
+ Hits          3677     3777     +100     
+ Misses         442      440       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Member

@omad omad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file is never directly executed, so I'd prefer to remove this line, and it doesn't need to be executable. It's probably an artefact of an old version of sphinx-quickstart.

conf.py in the official sphinx docs doesn't include one.

@omad omad force-pushed the hashbang-python3 branch from fc2a9b0 to 2cc5f76 Compare April 21, 2025 23:55
This file is never executed, so
remove the hashbang.
@pjonsson pjonsson changed the title Execute python3 instead of python docs/conf: remove hashbang Apr 22, 2025
@pjonsson
Copy link
Contributor Author

This file is never directly executed, so I'd prefer to remove this line

Even better, fixed!

@pjonsson pjonsson requested a review from omad April 22, 2025 15:24
@omad omad merged commit e442497 into opendatacube:develop Apr 23, 2025
7 checks passed
@pjonsson pjonsson deleted the hashbang-python3 branch April 23, 2025 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants