Skip to content

Conversation

pjonsson
Copy link
Contributor

@pjonsson pjonsson commented Sep 6, 2025

The function expects the iterable
to contain None.
The type checker is just missing information
for these, so ignore them.
This is what is currently returned,
so adjust the type to reflect that.
Copy link

codecov bot commented Sep 6, 2025

Codecov Report

❌ Patch coverage is 83.33333% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 84.33%. Comparing base (a6f12ce) to head (e7d08d9).
⚠️ Report is 6 commits behind head on develop.

Files with missing lines Patch % Lines
cubedash/summary/_stores.py 66.66% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #832      +/-   ##
===========================================
- Coverage    84.35%   84.33%   -0.02%     
===========================================
  Files           35       35              
  Lines         4244     4246       +2     
  Branches       537      537              
===========================================
+ Hits          3580     3581       +1     
- Misses         468      469       +1     
  Partials       196      196              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@omad omad merged commit b06d6d3 into opendatacube:develop Sep 6, 2025
13 checks passed
@pjonsson pjonsson deleted the stores-type-fixes branch September 6, 2025 22:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants