Various test fixes #838
Merged
Various test fixes #838
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #838 +/- ##
===========================================
+ Coverage 84.36% 84.43% +0.07%
===========================================
Files 35 35
Lines 4253 4253
Branches 537 537
===========================================
+ Hits 3588 3591 +3
+ Misses 469 467 -2
+ Partials 196 195 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
pjonsson
force-pushed
the
tests-fixes
branch
from
2f2f893 to
f050154
Compare
Accept None and assert that it is not expected inside the function. This fixes 9 type errors in the tests.
There is no return value from this function, so stop asserting on it.
This is required for type checking the tests.
pjonsson
force-pushed
the
tests-fixes
branch
from
f050154 to
0572dab
Compare
omad
approved these changes
Sep 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📚 Documentation preview 📚: https://datacube-explorer--838.org.readthedocs.build/en/838/