Skip to content

Conversation

pjonsson
Copy link
Contributor

@pjonsson pjonsson commented Sep 8, 2025

There is already a DropSchema in
stores, so put the CreateSchema
in there as well.

The previous code has some comment
about being able to run things
without create permissions, but
the only caller is SummaryStore.init()
whose documentation states that
it requires create permissions,
so use the if_not_exists parameter
to CreateSchema instead of some
function that probes the database.


📚 Documentation preview 📚: https://datacube-explorer--846.org.readthedocs.build/en/846/

There is already a DropSchema in
stores, so put the CreateSchema
in there as well.

The previous code has some comment
about being able to run things
without create permissions, but
the only caller is SummaryStore.init()
whose documentation states that
it requires create permissions,
so use the if_not_exists parameter
to CreateSchema instead of some
function that probes the database.
Copy link

codecov bot commented Sep 8, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.52%. Comparing base (ca2727b) to head (25bac00).
⚠️ Report is 7 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #846      +/-   ##
===========================================
+ Coverage    84.48%   84.52%   +0.03%     
===========================================
  Files           35       35              
  Lines         4248     4245       -3     
  Branches       538      536       -2     
===========================================
- Hits          3589     3588       -1     
  Misses         462      462              
+ Partials       197      195       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@omad omad merged commit c8455b4 into opendatacube:develop Sep 8, 2025
13 checks passed
@pjonsson pjonsson deleted the index-createschema branch September 8, 2025 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants