Remove python-dateutil dependency #861
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Switch to using the standard library for the UTC timezone in the remaining places that still use dateutil. Short-term this does not provide any benefit, but it makes it clear which parts of the code that require functionality beyond that of the standard library.
This has been untouched since 2018 and is only used by a single deactivated test. Move the dictionary to the test file and remove the unused LANDSAT_7/8 entries whose dates are now() - 2 months for some reason. This removes the last usage of dateutil.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #861 +/- ##
===========================================
- Coverage 84.52% 84.47% -0.05%
===========================================
Files 35 35
Lines 4245 4238 -7
Branches 536 536
===========================================
- Hits 3588 3580 -8
- Misses 462 463 +1
Partials 195 195 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Python 3.9 got a lot of the required support, and 3.10 got the remaining parts that Explorer is using. Switch to the standard library functions since this package requires Python 3.10.
📚 Documentation preview 📚: https://datacube-explorer--861.org.readthedocs.build/en/861/