CI: use OIDC for CodeCov #242
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pin the actions by hash so a compromised release of an action is not automatically used and leaks our secrets. This is not bulletproof, but better than nothing.
This uses a short-lived token which is better for security.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #242 +/- ##
========================================
Coverage 94.21% 94.21%
========================================
Files 34 34
Lines 5855 5855
========================================
Hits 5516 5516
Misses 339 339 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Considering the code coverage works, I don't think the CI failures are caused by this PR. |
omad
approved these changes
Aug 9, 2025
Agreed, thanks Peter, merging now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This uses a short-lived token
which is better for security.
Also pin the actions by hash
to make it harder to get
compromised if some action
gets compromised.