-
Notifications
You must be signed in to change notification settings - Fork 23
WIP: aux band support #229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
Kirill888
wants to merge
14
commits into
develop
Choose a base branch
from
kk-mdparse
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
+1,338
−227
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🚀 Deployed on https://f6d43600145741f0--odc-stac-docs.netlify.app |
* reduce number of places that deal with `md_plugin=None` case * implement `parse_item` as a special case of `parse_items`, and not the other way around * pass full config to `StacMDParser` * call driver_data with item, not asset
.meta is now present in the resolved config.
- mk_parsed_item can generate auxiliary bands from props={...} parameter. - unit tests for mk_parsed_item with props={...} parameter. - unit tests for StacAuxReader.read()
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #229 +/- ##
===========================================
- Coverage 90.18% 89.56% -0.62%
===========================================
Files 9 9
Lines 1222 1380 +158
===========================================
+ Hits 1102 1236 +134
- Misses 120 144 +24 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
When stac properties were captured into parsed item, put them into properties dict of the output stac item.
An auxiliary source can be detached from an asset, like for example when capturing properties as aux bands, skip those in bootstrap logic.
Allow to specify properties to load from STAC item as an independent parameter, rather than being in config only.
This allows custom geometry even when geobox is not provided, or no raster bands are provided. Also change most args to be keyword only.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
odc-loader=0.6.*
(auxiliary bands)StacAuxReader
class (STAC.properties ->xarray.DataArray
)