Skip to content

Conversation

emmaai
Copy link
Contributor

@emmaai emmaai commented Aug 6, 2024

Major changes:

  • added dask worker plugin for treelite predictor for multithreading safety
  • added a plugin class for all models of treelite as they share common routines
  • added plugins for woody cover and cultivated model
  • added tests for above changes

cultivated model diagram:
image

woody cover diagram
image

Minor changes:

Copy link

codecov bot commented Aug 6, 2024

Codecov Report

Attention: Patch coverage is 92.77457% with 25 lines in your changes missing coverage. Please review.

Project coverage is 79.63%. Comparing base (f066feb) to head (0985624).
Report is 1 commits behind head on develop.

Files Patch % Lines
odc/stats/plugins/lc_ml_treelite.py 81.17% 16 Missing ⚠️
odc/stats/model.py 0.00% 5 Missing ⚠️
odc/stats/plugins/lc_treelite_cultivated.py 97.29% 2 Missing ⚠️
odc/stats/plugins/lc_treelite_woody.py 95.12% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #146      +/-   ##
===========================================
+ Coverage    78.42%   79.63%   +1.20%     
===========================================
  Files           43       47       +4     
  Lines         3922     4263     +341     
===========================================
+ Hits          3076     3395     +319     
- Misses         846      868      +22     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@SpacemanPaul SpacemanPaul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't really understand what's happening here tbh, but looks clean enough.

@emmaai emmaai merged commit db360b0 into develop Aug 8, 2024
10 checks passed
@emmaai emmaai deleted the woody_cultivated_plugins branch August 8, 2024 02:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants