Skip to content

Conversation

tebadi
Copy link
Contributor

@tebadi tebadi commented Sep 12, 2024

No description provided.

@tebadi tebadi requested a review from emmaai September 12, 2024 02:15
Copy link

codecov bot commented Sep 12, 2024

Codecov Report

Attention: Patch coverage is 96.07843% with 2 lines in your changes missing coverage. Please review.

Project coverage is 79.89%. Comparing base (6a29afa) to head (f7906ad).
Report is 2 commits behind head on develop.

Files with missing lines Patch % Lines
odc/stats/plugins/lc_level3.py 93.33% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #151      +/-   ##
===========================================
+ Coverage    79.70%   79.89%   +0.19%     
===========================================
  Files           47       49       +2     
  Lines         4277     4328      +51     
===========================================
+ Hits          3409     3458      +49     
- Misses         868      870       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@emmaai emmaai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please enable precommit in your local repo and make sure all the lint pass before committing?

l34_dss = xx.classes_l3_l4
urban_dss = xx.urban_classes
cultivated_dss = xx.cultivated_class

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you either give the integer a name or comment what the number means?

cultivated_dss = xx.cultivated_class

cultivated_mask = l34_dss == 110
l34_cultivated_masked = xr.where(cultivated_mask, cultivated_dss, l34_dss)
Copy link
Contributor

@emmaai emmaai Sep 12, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cultivated is masked by the veg in input already, so it's just matter of merging valid data (data != nodata). Thought the logic pretty much the same, it's better to reflect that point and avoid the confusion.

Copy link
Contributor

@emmaai emmaai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@emmaai emmaai merged commit b960c1d into develop Sep 18, 2024
5 checks passed
@emmaai emmaai deleted the lccs_level3 branch September 18, 2024 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants