-
Notifications
You must be signed in to change notification settings - Fork 6
Added a plugin for processing level3 Land Cover product. #151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #151 +/- ##
===========================================
+ Coverage 79.70% 79.89% +0.19%
===========================================
Files 47 49 +2
Lines 4277 4328 +51
===========================================
+ Hits 3409 3458 +49
- Misses 868 870 +2 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please enable precommit in your local repo and make sure all the lint pass before committing?
l34_dss = xx.classes_l3_l4 | ||
urban_dss = xx.urban_classes | ||
cultivated_dss = xx.cultivated_class | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could you either give the integer a name or comment what the number means?
cultivated_dss = xx.cultivated_class | ||
|
||
cultivated_mask = l34_dss == 110 | ||
l34_cultivated_masked = xr.where(cultivated_mask, cultivated_dss, l34_dss) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cultivated is masked by the veg in input already, so it's just matter of merging valid data (data != nodata
). Thought the logic pretty much the same, it's better to reflect that point and avoid the confusion.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
No description provided.