Skip to content

Conversation

emmaai
Copy link
Contributor

@emmaai emmaai commented Dec 19, 2024

As the title, changes,

  • added nodata & artificial as artificial
  • altered test to cover the case and confirm no impact for the rest

@emmaai emmaai requested review from JM-GA and tebadi December 19, 2024 01:20
Copy link

codecov bot commented Dec 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.50%. Comparing base (0cf4d97) to head (1fb99de).
Report is 1 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #179   +/-   ##
========================================
  Coverage    81.50%   81.50%           
========================================
  Files           50       50           
  Lines         4600     4602    +2     
========================================
+ Hits          3749     3751    +2     
  Misses         851      851           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@emmaai emmaai merged commit 7ca53c0 into develop Dec 19, 2024
5 checks passed
@emmaai emmaai deleted the fix_building_top branch December 19, 2024 01:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants