Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
This resource produces a new version even when only the approval count has changed.
It doesn't make much sense to trigger a whole new build on approvals alone, especially when the configured minimum approvals hasn't changed.
I have simply removed the approvals count from the versions produced in gets and added it to the metadata instead.
Test Plan
Tested locally using 1.21.9.
Mitigation
This is kinda breaking, so I'd expect this in a major release bump.
At the same time I struggle to see who could have possibly benefited from current behaviour.
This could be put behind a feature flag, I'm just very beginner with Go so I'd need help.
Checklist
N/A
Will be done after confirming whether or not this needs a feature flag.
I can confirm that if this PR introduces a DB schema change, I have read and followed all the steps outlined in the Data Contract.N/A