Skip to content

Move approvals to metadata #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

gdupontf
Copy link

@gdupontf gdupontf commented May 3, 2024

Context

This resource produces a new version even when only the approval count has changed.
It doesn't make much sense to trigger a whole new build on approvals alone, especially when the configured minimum approvals hasn't changed.

I have simply removed the approvals count from the versions produced in gets and added it to the metadata instead.

Test Plan

Tested locally using 1.21.9.

Mitigation

This is kinda breaking, so I'd expect this in a major release bump.
At the same time I struggle to see who could have possibly benefited from current behaviour.
This could be put behind a feature flag, I'm just very beginner with Go so I'd need help.

Checklist

  • I have commented my code, particularly in hard-to-understand areas
    N/A
  • I have made corresponding changes to external documentation if necessary (READMEs, Confluence, etc.)
    Will be done after confirming whether or not this needs a feature flag.
  • I have checked that other PRs this PR depends on have already been deployed.
  • I can confirm that if this PR introduces a DB schema change, I have read and followed all the steps outlined in the Data Contract.
    N/A

@gdupontf
Copy link
Author

Any way to get eyes on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant