feat: change create_intent() to allow blank slug/name #862
+185
−54
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iloveagent57
approved these changes
Oct 2, 2025
Comment on lines
465
to
466
| else: | ||
| pass # Cases 1, 2, 3 |
There was a problem hiding this comment.
technicall we don't need this else. maybe a comment next to should_reserve_new_slug = False like "default to False, covers cases # 1, 2, 3
Comment on lines
+481
to
+491
| # Any of the following could be None since they're optional, in | ||
| # which case they would be unset, making this method act more | ||
| # like PUT than PATCH. |
There was a problem hiding this comment.
We should articulate this in the method docstring, too
This change is needed to support the use case of creating an intent WITHOUT an enterprise slug/name, such as during submission of the PlanDetails page (first page) of the checkout stepper. ENT-10756
pwnage101
force-pushed
the
pwnage101/ENT-10756
branch
from
c022bb7 to
797c185
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is needed to support the use case of creating an intent WITHOUT an enterprise slug/name, such as during submission of the PlanDetails page (first page) of the checkout stepper.
ENT-10756
Pairs with: edx/frontend-app-enterprise-checkout#60