fix: add forward slash between slug and url for admin portal url #864
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This pull request makes a small but important fix to the formatting of the admin portal URL for fulfilled checkout intents, ensuring a slash is present between the base URL and the enterprise slug. It also updates the related test to match the new URL formatting.
See the prod and stage config files for validation.
URL formatting fix:
admin_portal_url
property incustomer_billing/models.py
to include a slash (/
) betweenENTERPRISE_ADMIN_PORTAL_URL
andenterprise_slug
, ensuring correct URL construction.Test update:
test_models.py
to use the base URL without a trailing slash, aligning the test with the new URL formatting logic.Jira:
ENT-XXXX
Merge checklist:
./manage.py makemigrations
has been runPost merge: