Skip to content

Conversation

brobro10000
Copy link
Member

@brobro10000 brobro10000 commented Oct 2, 2025

Description:
This pull request makes a small but important fix to the formatting of the admin portal URL for fulfilled checkout intents, ensuring a slash is present between the base URL and the enterprise slug. It also updates the related test to match the new URL formatting.

See the prod and stage config files for validation.

  • URL formatting fix:

    • Updated the admin_portal_url property in customer_billing/models.py to include a slash (/) between ENTERPRISE_ADMIN_PORTAL_URL and enterprise_slug, ensuring correct URL construction.
  • Test update:

    • Modified the test in test_models.py to use the base URL without a trailing slash, aligning the test with the new URL formatting logic.

Jira:
ENT-XXXX

Merge checklist:

  • ./manage.py makemigrations has been run
    • Note: This must be run if you modified any models.
      • It may or may not make a migration depending on exactly what you modified, but it should still be run.

Post merge:

  • Ensure that your changes went out to the stage instance
  • Deploy to prod instance

@brobro10000 brobro10000 merged commit 430e301 into main Oct 2, 2025
4 checks passed
@brobro10000 brobro10000 deleted the hu/ent-admin-portal-url-fix branch October 2, 2025 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants