Skip to content

Conversation

iloveagent57
Copy link
Contributor

Re-opening in a different PR to get CI action to run. Runs fine locally.

Merge checklist:

  • ./manage.py makemigrations has been run
    • Note: This must be run if you modified any models.
      • It may or may not make a migration depending on exactly what you modified, but it should still be run.

Post merge:

  • Ensure that your changes went out to the stage instance
  • Deploy to prod instance

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Oct 6, 2025
@openedx-webhooks
Copy link

openedx-webhooks commented Oct 6, 2025

Thanks for the pull request, @iloveagent57!

This repository is currently maintained by @openedx/2u-enterprise.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.
🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads
🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.


Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@iloveagent57 iloveagent57 marked this pull request as ready for review October 6, 2025 13:47
@github-project-automation github-project-automation bot moved this to Needs Triage in Contributions Oct 6, 2025
@iloveagent57 iloveagent57 force-pushed the jenkins/upgrade-python-requirements-5091aa0 branch from 2c5ff0e to 8001c07 Compare October 6, 2025 13:58
@github-project-automation github-project-automation bot moved this from Needs Triage to Done in Contributions Oct 6, 2025
@iloveagent57 iloveagent57 reopened this Oct 6, 2025
@iloveagent57 iloveagent57 force-pushed the jenkins/upgrade-python-requirements-5091aa0 branch from 8001c07 to 81d53a6 Compare October 6, 2025 14:16
@iloveagent57 iloveagent57 force-pushed the jenkins/upgrade-python-requirements-5091aa0 branch from 81d53a6 to e361004 Compare October 6, 2025 14:33
Copy link
Member

@brobro10000 brobro10000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved to unblock

Do we know if this had any effect on the checkout experience beyond just the error methods being referenced directly?
Stripe customer/Stripe checkout session etc.

@iloveagent57 iloveagent57 merged commit 70818de into main Oct 6, 2025
4 checks passed
@iloveagent57 iloveagent57 deleted the jenkins/upgrade-python-requirements-5091aa0 branch October 6, 2025 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

open-source-contribution PR author is not from Axim or 2U

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants