feat!: compile to JS before publishing#1628
Conversation
a6720b4 to
67af0d0
Compare
0ea91ee to
006fc73
Compare
Configure the package to compile TypeScript and copy SCSS files to dist/ before publishing, rather than publishing raw source files. This allows us to use tsc-alias for @src imports. Also use a more modern export map to decouple the internal file structure from the package's API, and add a build step to CI. BREAKING CHANGE: Consuming projects may need to update their imports or SASS @use lines. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
006fc73 to
bc18e45
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## frontend-base #1628 +/- ##
================================================
Coverage ? 88.14%
================================================
Files ? 108
Lines ? 2024
Branches ? 549
================================================
Hits ? 1784
Misses ? 231
Partials ? 9 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ca87bba to
d3c422a
Compare
brian-smith-tcril
left a comment
There was a problem hiding this comment.
Overall this looks good, but the whole "make a temporary release" workflow seems like it has a lot of moving parts.
Personally I'd prefer to:
- Not make any temporary PR releases
- Run the package step on
if: github.event_name == 'pull_request'(I think that's the simpler syntax) - Use something like https://nightly.link/ to address the "it's annoying to dig through the build logs to find the artifact" issue
nightly.link even has an example workflow for leaving a comment on the PR with a link https://github.com/oprypin/nightly.link/blob/master/.github/workflows/pr-comment.yml
|
@brian-smith-tcril, I may have accidentally included the temporary release stuff in here, but it's completely separate now. |
The commits tab is still showing d3c422a |
d3c422a to
bc18e45
Compare
|
@brian-smith-tcril, missed a force-push, sorry. Should be good now. |
Configure the package to compile TypeScript and copy SCSS files to
dist/before publishing, rather than publishing raw source files. This allows us to use tsc-alias for@srcimports.Also use a more modern export map to decouple the internal file structure from the package's API, and add a build step to CI.
BREAKING CHANGE
Consuming projects may need to update their imports or SASS
@uselines.Depends on
openedx/frontend-base#164
LLM Usage Notice
Built with assistance from Claude Opus 4.6.