Skip to content

Comments

feat!: compile to JS before publishing#1628

Merged
arbrandes merged 1 commit intoopenedx:frontend-basefrom
arbrandes:frontend-base-compile-before-publishing
Feb 13, 2026
Merged

feat!: compile to JS before publishing#1628
arbrandes merged 1 commit intoopenedx:frontend-basefrom
arbrandes:frontend-base-compile-before-publishing

Conversation

@arbrandes
Copy link
Contributor

@arbrandes arbrandes commented Feb 6, 2026

Configure the package to compile TypeScript and copy SCSS files to dist/ before publishing, rather than publishing raw source files. This allows us to use tsc-alias for @src imports.

Also use a more modern export map to decouple the internal file structure from the package's API, and add a build step to CI.

BREAKING CHANGE

Consuming projects may need to update their imports or SASS @use lines.

Depends on

openedx/frontend-base#164

LLM Usage Notice

Built with assistance from Claude Opus 4.6.

Configure the package to compile TypeScript and copy SCSS files to dist/
before publishing, rather than publishing raw source files. This allows
us to use tsc-alias for @src imports.

Also use a more modern export map to decouple the internal file
structure from the package's API, and add a build step to CI.

BREAKING CHANGE: Consuming projects may need to update their imports or
SASS @use lines.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@arbrandes arbrandes force-pushed the frontend-base-compile-before-publishing branch from 006fc73 to bc18e45 Compare February 11, 2026 15:12
@codecov
Copy link

codecov bot commented Feb 11, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (frontend-base@92208a0). Learn more about missing BASE report.

Additional details and impacted files
@@               Coverage Diff                @@
##             frontend-base    #1628   +/-   ##
================================================
  Coverage                 ?   88.14%           
================================================
  Files                    ?      108           
  Lines                    ?     2024           
  Branches                 ?      549           
================================================
  Hits                     ?     1784           
  Misses                   ?      231           
  Partials                 ?        9           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@arbrandes arbrandes marked this pull request as ready for review February 11, 2026 15:17
@arbrandes arbrandes force-pushed the frontend-base-compile-before-publishing branch 2 times, most recently from ca87bba to d3c422a Compare February 11, 2026 19:35
@arbrandes arbrandes removed the package label Feb 11, 2026
Copy link
Contributor

@brian-smith-tcril brian-smith-tcril left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall this looks good, but the whole "make a temporary release" workflow seems like it has a lot of moving parts.

Personally I'd prefer to:

  • Not make any temporary PR releases
  • Run the package step on if: github.event_name == 'pull_request' (I think that's the simpler syntax)
  • Use something like https://nightly.link/ to address the "it's annoying to dig through the build logs to find the artifact" issue

nightly.link even has an example workflow for leaving a comment on the PR with a link https://github.com/oprypin/nightly.link/blob/master/.github/workflows/pr-comment.yml

@arbrandes
Copy link
Contributor Author

@brian-smith-tcril, I may have accidentally included the temporary release stuff in here, but it's completely separate now.

@brian-smith-tcril
Copy link
Contributor

@brian-smith-tcril, I may have accidentally included the temporary release stuff in here, but it's completely separate now.

The commits tab is still showing d3c422a

@arbrandes arbrandes force-pushed the frontend-base-compile-before-publishing branch from d3c422a to bc18e45 Compare February 13, 2026 17:45
@arbrandes
Copy link
Contributor Author

@brian-smith-tcril, missed a force-push, sorry. Should be good now.

Copy link
Contributor

@brian-smith-tcril brian-smith-tcril left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@arbrandes arbrandes merged commit b9f2c5d into openedx:frontend-base Feb 13, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants