feat: hide shell header and footer dynamically#1663
Merged
arbrandes merged 1 commit intoopenedx:frontend-basefrom Apr 10, 2026
Merged
feat: hide shell header and footer dynamically#1663arbrandes merged 1 commit intoopenedx:frontend-basefrom
arbrandes merged 1 commit intoopenedx:frontend-basefrom
Conversation
arbrandes
force-pushed
the
dynamic-hide-header-footer
branch
from
02075fe to
503949b
Compare
arbrandes
changed the title
arbrandes
force-pushed
the
dynamic-hide-header-footer
branch
from
503949b to
a149531
Compare
Co-Authored-By: Claude <noreply@anthropic.com>
arbrandes
force-pushed
the
dynamic-hide-header-footer
branch
from
a149531 to
f3e253a
Compare
brian-smith-tcril
approved these changes
Apr 10, 2026
Contributor
brian-smith-tcril
left a comment
brian-smith-tcril
left a comment
There was a problem hiding this comment.
LGTM!
What I was in the middle of writing before this updated
Once this includes a package-lock.json update the
Module '"@openedx/frontend-base"' has no exported member 'providesChromelessRolesId'.
problem should go away.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## frontend-base #1663 +/- ##
================================================
Coverage ? 92.08%
================================================
Files ? 93
Lines ? 2046
Branches ? 588
================================================
Hits ? 1884
Misses ? 159
Partials ? 3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
🎉 This PR is included in version 1.0.0-alpha.10 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Uses the new
providesmechanism from frontend-base to declare which authn roles should trigger chromeless mode (no shell header or footer). All five authn roles (login, register, resetPassword, confirmPassword, welcome) are listed underprovidesChromelessRolesId, preserving the existing behavior where header and footer are hidden on all authn pages.Depends on openedx/frontend-base#220.
LLM usage notice
Built with assistance from Claude.