Skip to content

fix: answer range format validation and error message in Numerical input #1557

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

ihor-romaniuk
Copy link
Contributor

@ihor-romaniuk ihor-romaniuk commented Dec 9, 2024

Backport Pull Requests to frontend-lib-content-components: openedx-unsupported/frontend-lib-content-components#511

Description

These fixes validate input range format; it accepts the following response forms: [1,10], [1, 10], [ 1,10 ], [ 1, 10 ], [1, 10 ] , [ 1, 10], [1.1,10], [1.1,10.1], [1.1,10.1] and display error on incorrect format like: [1.10], [1;10], [1/10], etc.

Steps to reproduce

  1. Go to studio -> unit -> problem -> Numerical input
  2. In answers click on Add answer button -> Add answer range
  3. Fill in value [5.8), click Save (like user set dot instead of comma by mistake)

Actual result

Nothing happened, in console there's error
000
Note: the same when user print additional bracket

Expected result

Some validation should be for field or some error message for user should be shown
Before save:
0001
After save:
0002

@ihor-romaniuk ihor-romaniuk requested a review from a team as a code owner December 9, 2024 15:21
@openedx-webhooks
Copy link

openedx-webhooks commented Dec 9, 2024

Thanks for the pull request, @ihor-romaniuk!

This repository is currently maintained by @bradenmacdonald.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.
🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads
🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.


Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

Copy link

codecov bot commented Dec 9, 2024

Codecov Report

Attention: Patch coverage is 93.33333% with 1 line in your changes missing coverage. Please review.

Project coverage is 94.18%. Comparing base (aeefcc6) to head (f2f768d).

Files with missing lines Patch % Lines
...ntainers/ProblemEditor/data/ReactStateOLXParser.js 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1557      +/-   ##
==========================================
+ Coverage   94.15%   94.18%   +0.02%     
==========================================
  Files        1164     1164              
  Lines       24599    24612      +13     
  Branches     5381     5385       +4     
==========================================
+ Hits        23162    23180      +18     
+ Misses       1360     1355       -5     
  Partials       77       77              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ihor-romaniuk ihor-romaniuk force-pushed the romaniuk/answer-range-validation branch from 23aa397 to 61ca0b4 Compare June 26, 2025 08:04
@ihor-romaniuk ihor-romaniuk force-pushed the romaniuk/answer-range-validation branch from d8236e0 to f2f768d Compare June 26, 2025 08:59
Arpit-Nakrani-Networked pushed a commit to Arpit-Nakrani-Networked/frontend-app-authoring that referenced this pull request Jul 13, 2025
@@ -57,6 +57,8 @@ export const responseKeys = [
'choicetextresponse',
];

export const answerRangeFormatRegex = /^[([]\s*\d+(\.\d+)?\s*,\s*\d+(\.\d+)?\s*[)\]]$/m;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a JSDoc comment explaining what this is in detail, including examples of valid values.

@@ -47,6 +48,11 @@ const AnswerOption = ({
staticRootUrl = `${getConfig().STUDIO_BASE_URL }/library_assets/blocks/${ blockId }/`;
}

const validateAnswerTitle = (value) => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this function called validateAnswerTitle ; shouldn't it be validateAnswerRange ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
open-source-contribution PR author is not from Axim or 2U
Projects
Status: Waiting on Author
Development

Successfully merging this pull request may close these issues.

3 participants