-
Notifications
You must be signed in to change notification settings - Fork 142
fix: answer range format validation and error message in Numerical input #1557
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
fix: answer range format validation and error message in Numerical input #1557
Conversation
Thanks for the pull request, @ihor-romaniuk! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1557 +/- ##
==========================================
+ Coverage 94.15% 94.18% +0.02%
==========================================
Files 1164 1164
Lines 24599 24612 +13
Branches 5381 5385 +4
==========================================
+ Hits 23162 23180 +18
+ Misses 1360 1355 -5
Partials 77 77 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
23aa397
to
61ca0b4
Compare
d8236e0
to
f2f768d
Compare
@@ -57,6 +57,8 @@ export const responseKeys = [ | |||
'choicetextresponse', | |||
]; | |||
|
|||
export const answerRangeFormatRegex = /^[([]\s*\d+(\.\d+)?\s*,\s*\d+(\.\d+)?\s*[)\]]$/m; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add a JSDoc comment explaining what this is in detail, including examples of valid values.
@@ -47,6 +48,11 @@ const AnswerOption = ({ | |||
staticRootUrl = `${getConfig().STUDIO_BASE_URL }/library_assets/blocks/${ blockId }/`; | |||
} | |||
|
|||
const validateAnswerTitle = (value) => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this function called validateAnswerTitle
; shouldn't it be validateAnswerRange
?
Backport Pull Requests to frontend-lib-content-components: openedx-unsupported/frontend-lib-content-components#511
Description
These fixes validate input range format; it accepts the following response forms:
[1,10]
,[1, 10]
,[ 1,10 ]
,[ 1, 10 ]
,[1, 10 ]
,[ 1, 10]
,[1.1,10]
,[1.1,10.1]
,[1.1,10.1]
and display error on incorrect format like:[1.10]
,[1;10]
,[1/10]
, etc.Steps to reproduce
Actual result
Nothing happened, in console there's error

Note: the same when user print additional bracket
Expected result
Some validation should be for field or some error message for user should be shown


Before save:
After save: