-
Notifications
You must be signed in to change notification settings - Fork 162
feat: enable markdown to olx conversion #2518
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Thanks for the pull request, @Anas12091101! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2518 +/- ##
=======================================
Coverage 94.68% 94.69%
=======================================
Files 1203 1203
Lines 26865 26876 +11
Branches 6026 6032 +6
=======================================
+ Hits 25438 25449 +11
Misses 1357 1357
Partials 70 70 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
82428e5
to
f3e2511
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
const state = getState(); | ||
export const switchToAdvancedEditor = (editorRef) => (dispatch, getState) => { | ||
const { problem } = getState(); | ||
const editorObject = fetchEditorContent({ format: '' }); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we move this editorObject
down inside the else {
clause?
problemType: PropTypes.string.isRequired, | ||
editorType: PropTypes.string.isRequired, | ||
// eslint-disable-next-line react/forbid-prop-types | ||
editorRef: PropTypes.object.isRequired, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is fine, but I would have preferred we pass the editorRef around using a ProblemEditorContext
instead of prop drilling.
Description
This PR enables the conversion from Markdown to OLX. The reverse conversion (OLX to Markdown) has been deferred for now, as it would require implementing a dedicated OLX-to-Markdown converter, which may take additional time. We plan to address that in a future update to ensure this change is merged before the Ulmo cut.
Useful information to include:
In Course
https://github.com/user-attachments/assets/cafee2fe-5445-4ec5-b90a-8b2d9b54d9f3
In Library
https://github.com/user-attachments/assets/98f45954-2d11-4dec-abcc-cc75d537882a
Supporting information
#1920
https://github.com/mitodl/hq/issues/8729
Testing instructions
Other information
Include anything else that will help reviewers and consumers understand the change.
Best Practices Checklist
We're trying to move away from some deprecated patterns in this codebase. Please
check if your PR meets these recommendations before asking for a review:
.ts
,.tsx
).propTypes
,defaultProps
, andinjectIntl
patterns are not used in any new or modified code.src/testUtils.tsx
(specificallyinitializeMocks
)apiHooks.ts
in this repo for examples.messages.ts
files have adescription
for translators to use.../
. To import from parent folders, use@src
, e.g.import { initializeMocks } from '@src/testUtils';
instead offrom '../../../../testUtils'