Skip to content

Conversation

rpenido
Copy link
Contributor

@rpenido rpenido commented Oct 14, 2025

Description

This PR adds copy support for Library Containers and updates the useClipboard hook to provide info on copied containers.

Useful information to include:

  • Which user roles will this change impact?
    "Course Author" and "Developer"

Testing instructions

  • In a library, create a Section, Subsection, Unit, Components structure

  • Copy the Section using the menu on the Card

  • Paste the Section in the same library, using + New > Paste from Clipboard

  • Only the top-level Section should be duplicated in the library, and the children's subsection should be linked in the new section

  • Paste the same action into another library

  • The whole structure should be created in the library

Deadline

2025-10-23 (Ulmo cut)

Best Practices Checklist

We're trying to move away from some deprecated patterns in this codebase. Please
check if your PR meets these recommendations before asking for a review:

  • Any new files are using TypeScript (.ts, .tsx).
  • Deprecated propTypes, defaultProps, and injectIntl patterns are not used in any new or modified code.
  • Tests should use the helpers in src/testUtils.tsx (specifically initializeMocks)
  • Do not add new fields to the Redux state/store. Use React Context to share state among multiple components.
  • Use React Query to load data from REST APIs. See any apiHooks.ts in this repo for examples.
  • All new i18n messages in messages.ts files have a description for translators to use.
  • Imports avoid using ../. To import from parent folders, use @src, e.g. import { initializeMocks } from '@src/testUtils'; instead of from '../../../../testUtils'

Private ref: FAL-4242

@openedx-webhooks
Copy link

openedx-webhooks commented Oct 14, 2025

Thanks for the pull request, @rpenido!

This repository is currently maintained by @bradenmacdonald.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.
🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads
🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.


Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Oct 14, 2025
@github-project-automation github-project-automation bot moved this to Needs Triage in Contributions Oct 14, 2025
@rpenido rpenido force-pushed the rpenido/fal-4242/copy-container-ui branch 6 times, most recently from 56fdcde to fc05be5 Compare October 15, 2025 14:25
Copy link

codecov bot commented Oct 15, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.73%. Comparing base (9c0b545) to head (2a4d125).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2538   +/-   ##
=======================================
  Coverage   94.72%   94.73%           
=======================================
  Files        1205     1205           
  Lines       26939    26967   +28     
  Branches     5893     5906   +13     
=======================================
+ Hits        25518    25546   +28     
  Misses       1362     1362           
  Partials       59       59           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@rpenido rpenido force-pushed the rpenido/fal-4242/copy-container-ui branch from fc05be5 to 2a4d125 Compare October 15, 2025 14:54
@rpenido rpenido marked this pull request as ready for review October 15, 2025 17:46
@mphilbrick211 mphilbrick211 moved this from Needs Triage to Ready for Review in Contributions Oct 15, 2025
@bradenmacdonald bradenmacdonald changed the title feat: add copy container menu feat: add copy container menu [FC-0097] Oct 15, 2025
@bradenmacdonald bradenmacdonald added the FC Relates to an Axim Funded Contribution project label Oct 15, 2025
@rpenido rpenido requested a review from navinkarkera October 15, 2025 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

FC Relates to an Axim Funded Contribution project open-source-contribution PR author is not from Axim or 2U

Projects

Status: Ready for Review

Development

Successfully merging this pull request may close these issues.

3 participants