-
Notifications
You must be signed in to change notification settings - Fork 53
build: remove unused @edx/reactifex package #256
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #256 +/- ##
=======================================
Coverage 84.14% 84.14%
=======================================
Files 47 47
Lines 700 700
Branches 135 135
=======================================
Hits 589 589
Misses 111 111 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
4b4bc6e
to
95eb4d2
Compare
@openedx/committers-frontend Can you check my approach on this, when I updated the package.json and re-built package-lock.json for a different change (dropping reactifex), it pulled in a new version of frontend-component-header which now has typescript components. Adding the tsconfig and updating the eslint ignore seems to have gotten the build passing but I wanted to make sure it's the correct approach before I apply the changes to other related PRs that are seeing this issue. |
These changes look similar to the ones made in #254 It seems openedx/frontend-component-header#604 should have landed as a breaking change, but renovate landed it on repos that already had |
Looking at the log, it shows errors about |
The build step does seem a bit odd (https://github.com/openedx/frontend-component-header/blob/ecf7f1dfc1da11ae32c36f4cae5fcfb45733ea5b/Makefile#L8-L14) For now I've just marked the |
Remove @edx/reactifex package from devDependencies as it is no longer needed. Translation extraction functionality has been verified to work correctly without this dependency. Co-Authored-By: Claude <noreply@anthropic.com>
This test should be suppling a `courseModes` parameter not a `courseMode` parameter with a missing `s`.
41d8ef0
to
1c9e20e
Compare
Remove @edx/reactifex package from devDependencies as it is no longer
needed. Translation extraction functionality has been verified to work
correctly without this dependency.
🤖 Generated with Claude Code
Co-Authored-By: Claude noreply@anthropic.com