Skip to content

Conversation

@arbrandes
Copy link
Contributor

@arbrandes arbrandes commented Dec 6, 2024

(This is a Sumac-specific change!)

Description

This removes the upgrade button as default content in CourseCardActionSlot.

This is, for the moment, a Sumac-specific change. The button is still present in master, pending proper removal (including the component definitions from the rest of the repository) prior to the U release by the maintainers. See:

#438

Screenshots

Before:

image

After:

image

This removes the upgrade button as default content in CourseCardActionSlot.

This is, for the moment, a Sumac-specific change.  The button is still
present in master, pending proper removal (including the component
definitions from the rest of the repository) prior to the U release by
the maintainers.  See:

openedx#438
@arbrandes arbrandes requested a review from a team as a code owner December 6, 2024 18:04
@arbrandes arbrandes changed the title feat: remove upgrade button feat: remove upgrade button [Sumac] Dec 6, 2024
@codecov
Copy link

codecov bot commented Dec 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (open-release/sumac.master@8e0e217). Learn more about missing BASE report.

Additional details and impacted files
@@                     Coverage Diff                      @@
##             open-release/sumac.master     #525   +/-   ##
============================================================
  Coverage                             ?   97.40%           
============================================================
  Files                                ?      157           
  Lines                                ?     1386           
  Branches                             ?      231           
============================================================
  Hits                                 ?     1350           
  Misses                               ?       34           
  Partials                             ?        2           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@brian-smith-tcril brian-smith-tcril left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@arbrandes arbrandes merged commit 021f52b into openedx:open-release/sumac.master Dec 6, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants