test: Add Node 24 to CI matrix

[PKulkoRaccoonGang]

Description

As a first step in the upgrade to Node 24, add it to the CI matrix as a non-blocking test.

See the tracking issue for further information.

[openedx-webhooks]

Thanks for the pull request, @PKulkoRaccoonGang!

This repository is currently maintained by @2U-aperture.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

• If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
  • This process (including the steps you'll need to take) is documented here.
• If it doesn't, simply proceed with the next step.

🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

• Dependencies

  This PR must be merged before / after / at the same time as ...

• Blockers

  This PR is waiting for OEP-1234 to be accepted.

• Timeline information

  This PR must be merged by XX date because ...

• Partner information

  This is for a course on edx.org.

• Supporting documentation
• Relevant Open edX discussion forum threads

🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

---

Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

• Overview of Review Process for Community Contributions
• Pull Request Status Guide
• Making changes to your pull request

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

• The size and impact of the changes that it introduces
• The need for product review
• Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.65%. Comparing base (9e4faf1) to head (18b6e1d).
⚠️ Report is 15 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #701      +/-   ##
==========================================
+ Coverage   97.60%   97.65%   +0.05%     
==========================================
  Files         152      156       +4     
  Lines        1337     1367      +30     
  Branches      232      234       +2     
==========================================
+ Hits         1305     1335      +30     
  Misses         31       31              
  Partials        1        1              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[itsjeyd]

@PKulkoRaccoonGang Thank you for this contribution! Please let us know when it is ready for review.

[PKulkoRaccoonGang]

@itsjeyd the first PR on the way to the upgrade to Node JS 24 for frontend-app-learner-dashboard is ready for review. Please take a look

[deborahgu]

@MaxFrank13 could you verify this when you have time?

[itsjeyd]

@PKulkoRaccoonGang

@itsjeyd the first PR on the way to the upgrade to Node JS 24 for frontend-app-learner-dashboard is ready for review. Please take a look

Same note here, I'll remove myself from the list of reviewers for this PR now.

[itsjeyd]

@MaxFrank13 Thanks for picking up the review for this PR!

It looks like it's pretty much ready to go, aside from the fact that one of the automated checks is still pending. Would you be able to run it?

[MaxFrank13]

@PKulkoRaccoonGang @itsjeyd I think we need to merge the latest changes from master and that should get the check that is stuck to re-run.

FWIW, I've tried re-running the test workflow and that didn't seem to effect anything.

[PKulkoRaccoonGang]

FWIW, I've tried re-running the test workflow and that didn't seem to effect anything.

I have encountered the problem with "1 pending check" in other MFEs. As a result, when we merge the entire sequence of PRs for the upgrade Node JS version, there should be no problems.

[MaxFrank13]

I have encountered the problem with "1 pending check" in other MFEs. As a result, when we merge the entire sequence of PRs for the upgrade Node JS version, there should be no problems.

Okay so does this mean we don't want to merge it yet?

[PKulkoRaccoonGang]

@MaxFrank13 We have a sequence of three PRs related to upgrading to Node.js 24:

1. test: Add Node 24 to CI matrix - this PR (currently under review)
2. build: Upgrade to Node 24 - next in line; once this PR is merged, it will be updated and ready for review
3. test: Remove support for Node 20 - the final PR in the Node.js 24 upgrade sequence

The last PR does not encounter the "1 pending check" issue. Given this, I suggest merging this PR.

[MaxFrank13]

I agree we should merge the PR, but are we able to do that with the pending check still there? I don't see an option to do so

[itsjeyd]

I agree we should merge the PR, but are we able to do that with the pending check still there? I don't see an option to do so

@openedx/axim-engineering Could you help @PKulkoRaccoonGang and @MaxFrank13 with this? ⬆️ For context see #701 (comment) and comments that follow.

[bmtcril]

Going to close and reopen to see if that clears the hung test status

[sarina]

I know what the problem is, there's now a test matrix, so tests no longer exists as a check (now it is tests (20) and tests (24).

I can remove tests as a required check, but let me know what should be required.

[brian-smith-tcril]

To go with the goal of adding 24 as non-blocking, I updated the branch requirement to check for "tests (20)"