docs: add ADR about using caret ranges for npm deps #687
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feanil
approved these changes
Feb 27, 2025
sarina
reviewed
Mar 11, 2025
There was a problem hiding this comment.
@adamstankiewicz is there anyone else we should tag for review on this?
oeps/best-practices/oep-0067/decisions/frontend/0011-caret-ranges-dependencies.rst
Show resolved
Hide resolved
Perhaps @brian-smith-tcril and @arbrandes can provide an additional review? |
brian-smith-tcril
approved these changes
Mar 11, 2025
oeps/best-practices/oep-0067/decisions/frontend/0011-caret-ranges-dependencies.rst
Outdated
Show resolved
Hide resolved
Co-authored-by: Brian Smith <112954497+brian-smith-tcril@users.noreply.github.com> Co-authored-by: Sarina Canelake <sarina@axim.org>
sarina
approved these changes
Mar 12, 2025
|
@adamstankiewicz - I think this is ready to merge, unless you have further work to do on it? |
@sarina All set to merge on my end! Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds an ADR under OEP-67 "Frontend Technology Selection"'s best practices to codify the (updated) recommendation to no longer pin dependencies in
package.json, in favor of using caret ranges.