-
Notifications
You must be signed in to change notification settings - Fork 9
feat: Save enrollment action preferences #111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks for the pull request, @ramadanomar! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
i have signed it |
Thanks @ramadanomar! Looks like there are a couple failing checks. |
I'll sort them out tomorrow. |
Hello, @ramadanomar. Thanks for your contribution. ✨ I only want to let you know I'll be out for 2 weeks. When I return, I can take a look at this. Meanwhile, you can go over the failing tests. |
1be25de
to
86d446d
Compare
978b903
to
e1dab2c
Compare
Thanks for all the help landing this @MaferMazu. @ramadanomar thanks for your contribution. I had to rebase a few times to get the CI to cooperate |
fix: linting the settings file fix: linting
e1dab2c
to
a112b59
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested this locally and fixed the CI errors.
Then I tested remotelly and created a few enrollments in a test site
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suggest adding to the changelog something like this:
## v2.1.0 - 2025-08-05
### [2.1.0](https://github.com/openedx/openedx-wordpress-ecommerce/compare/v2.0.7...v2.1.0) (2025-08-05)
#### Features
* feat: add publish to wordpress svn action (#103)
* feat: Save enrollment action preferences (#111)
#### Bug Fixes
* fix: add parent property to avoid dynamic property warning (#109)
* fix: updating i18n management (2025 best practices) (#114)
### Documentation
* docs: add automatic installation info and change github docs links to rtd docs (#108)
### Maintenance
* chore: actions auto updates.
* chore: Tag this repo as part of named releases (#110)
And also I think we should improve the documentation by changing the image /_images/how-tos/create_an_openedx_app/openedx-sync-plugin-settings.png
to reflect the new settings, and add a line in the plugin_quickstart.rst
that says something about the first configurations are required for the WordPress plugin to work, and then you have more options to configure the behavior of it.
The rest looks good to me, I tested it and it works. ✅
Thanks for pushing this forward, @felipemontoya.
@MaferMazu I added the changelog. Modifiying the documentation is also nice, but I think we should not block the PR based on that. |
Description
Added the ability to save the preffered configuration values for 'openedx-enrollment-force' and 'openedx-enrollment-allowed'. This is needed to be able to enroll users that have no openedx account yet and/or enroll users to courses that have already started without manual intervation from an admin.
Without this, an admin will have to check failed enrollment requests and retry them from "openedx sync" tab in wordpress.
This would result in a really bad end user experience (purchase was made but access isn't given)
Useful information to include:
Screenshots
Checklist for Merge