Skip to content

Conversation

ramadanomar
Copy link
Contributor

@ramadanomar ramadanomar commented Mar 21, 2025

Description

Added the ability to save the preffered configuration values for 'openedx-enrollment-force' and 'openedx-enrollment-allowed'. This is needed to be able to enroll users that have no openedx account yet and/or enroll users to courses that have already started without manual intervation from an admin.

Without this, an admin will have to check failed enrollment requests and retry them from "openedx sync" tab in wordpress.

image

This would result in a really bad end user experience (purchase was made but access isn't given)

Useful information to include:

  • Which user roles will this change impact? Operator

Screenshots

Screenshot from 2025-03-24 11-22-04

Checklist for Merge

  • Tested in a remote environment
  • Updated documentation
  • Rebased master/main
  • Squashed commits

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Mar 21, 2025
@openedx-webhooks
Copy link

openedx-webhooks commented Mar 21, 2025

Thanks for the pull request, @ramadanomar!

This repository is currently maintained by @mafermazu.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.
🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads
🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.


Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@github-project-automation github-project-automation bot moved this to Needs Triage in Contributions Mar 21, 2025
@ramadanomar ramadanomar changed the title DRAFT: Save enrollment action preferences feat: Save enrollment action preferences Mar 24, 2025
@ramadanomar ramadanomar marked this pull request as ready for review March 24, 2025 09:42
@mphilbrick211 mphilbrick211 added the needs test run Author's first PR to this repository, awaiting test authorization from Axim label Mar 24, 2025
@mphilbrick211 mphilbrick211 moved this from Needs Triage to Needs Tests Run or CLA Signed in Contributions Mar 24, 2025
@ramadanomar
Copy link
Contributor Author

i have signed it

@mphilbrick211 mphilbrick211 removed the needs test run Author's first PR to this repository, awaiting test authorization from Axim label Apr 1, 2025
@mphilbrick211 mphilbrick211 moved this from Needs Tests Run or CLA Signed to Waiting on Author in Contributions Apr 1, 2025
@mphilbrick211
Copy link

Thanks @ramadanomar! Looks like there are a couple failing checks.

@ramadanomar
Copy link
Contributor Author

I'll sort them out tomorrow.

@MaferMazu
Copy link
Contributor

Hello, @ramadanomar. Thanks for your contribution. ✨

I only want to let you know I'll be out for 2 weeks. When I return, I can take a look at this. Meanwhile, you can go over the failing tests.

@felipemontoya felipemontoya mentioned this pull request Aug 4, 2025
6 tasks
@felipemontoya felipemontoya force-pushed the save-enrollment-action branch from 1be25de to 86d446d Compare August 4, 2025 21:34
@felipemontoya felipemontoya force-pushed the save-enrollment-action branch 2 times, most recently from 978b903 to e1dab2c Compare August 4, 2025 22:44
@felipemontoya felipemontoya requested a review from MaferMazu August 4, 2025 22:47
@felipemontoya
Copy link
Member

Thanks for all the help landing this @MaferMazu.

@ramadanomar thanks for your contribution. I had to rebase a few times to get the CI to cooperate

@felipemontoya felipemontoya force-pushed the save-enrollment-action branch from e1dab2c to a112b59 Compare August 4, 2025 22:56
Copy link
Member

@felipemontoya felipemontoya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested this locally and fixed the CI errors.

Then I tested remotelly and created a few enrollments in a test site

Copy link
Contributor

@MaferMazu MaferMazu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest adding to the changelog something like this:

## v2.1.0 - 2025-08-05

### [2.1.0](https://github.com/openedx/openedx-wordpress-ecommerce/compare/v2.0.7...v2.1.0) (2025-08-05)

#### Features

* feat: add publish to wordpress svn action (#103)
* feat: Save enrollment action preferences (#111)

#### Bug Fixes

* fix: add parent property to avoid dynamic property warning (#109)
* fix: updating i18n management (2025 best practices) (#114)

### Documentation

* docs: add automatic installation info and change github docs links to rtd docs (#108)

### Maintenance

* chore: actions auto updates.
* chore: Tag this repo as part of named releases (#110)

And also I think we should improve the documentation by changing the image /_images/how-tos/create_an_openedx_app/openedx-sync-plugin-settings.png to reflect the new settings, and add a line in the plugin_quickstart.rst that says something about the first configurations are required for the WordPress plugin to work, and then you have more options to configure the behavior of it.


The rest looks good to me, I tested it and it works. ✅
Thanks for pushing this forward, @felipemontoya.

@felipemontoya
Copy link
Member

felipemontoya commented Aug 5, 2025

@MaferMazu I added the changelog. Modifiying the documentation is also nice, but I think we should not block the PR based on that.

@MaferMazu MaferMazu merged commit 80e1e75 into openedx:main Aug 5, 2025
5 checks passed
@github-project-automation github-project-automation bot moved this from Waiting on Author to Done in Contributions Aug 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

open-source-contribution PR author is not from Axim or 2U

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

5 participants