fix: newly created children lack is_external

Author: alexgarel

backend/editor/controllers/node_controller.py

@@ -40,6 +40,7 @@ async def create_entry_node(
         f"tags_{language_code}": [name],
         f"tags_ids_{language_code}": [normalized_name],
         "modified": datetime.datetime.now().timestamp(),
+        "is_external": False,
     }
     params = {"entry_node": entry_node_data}
 

backend/tests/test_export.py

@@ -167,6 +167,30 @@ async def test_no_comment_repeat(taxonomy_test):
     background_tasks.run()
 
 
+@pytest.mark.anyio
+async def test_add_bare_child(taxonomy_test):
+    async with graph_db.TransactionCtx():
+        # add a children to "en:yogurts", without any other properties
+        children = await taxonomy_test.get_children("en:yogurts")
+        children_ids = [record["child.id"] for record in children]
+        children_ids.append("en:sweet yogurts")
+        await taxonomy_test.update_node_children("en:yogurts", children_ids)
+    background_tasks = FakeBackgroundTask()
+    file_path = taxonomy_test.dump_taxonomy(background_tasks)
+    result = list(open(file_path))
+    # expected output
+    expected = list(open("tests/data/test.txt"))
+    # new entry inserted just after yogurts, the parent
+    expected[16:16] = [
+        "< en:yogurts\n",
+        "en: sweet yogurts\n",
+        "\n",
+    ]
+    assert result == expected
+    # clean files
+    background_tasks.run()
+
+
 @pytest.mark.anyio
 async def test_add_new_entry_as_child(taxonomy_test):
     async with graph_db.TransactionCtx():

parser/openfoodfacts_taxonomy_parser/patcher.py

@@ -23,7 +23,7 @@ def get_all_nodes(self, project_label):
             MATCH (n:({project_label}|REMOVED_{project_label}))
             WHERE
                 // no external node
-                n.is_external = false
+                (n.is_external = false OR n.is_external IS NULL)
                 AND (
                     // modified nodes
                     ((n:TEXT OR n:SYNONYMS OR n:STOPWORDS OR n:ENTRY) AND n.modified IS NOT NULL)