Skip to content

fix: bad tables dom on errors and search results #556

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 20, 2024
Merged

fix: bad tables dom on errors and search results #556

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f30bc17
fix: bad tables dom on errors and search results
alexgarel Dec 20, 2024
b8b430f
refactor: lint
alexgarel Dec 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions taxonomy-editor-frontend/src/components/EntryNodesTableBody.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ import {
Tooltip,
Typography,
} from "@mui/material";
import { Link } from "react-router-dom";
import { useNavigate } from "react-router-dom";
import ISO6391 from "iso-639-1";
import { useEffect, useState } from "react";
import { SHOWN_LANGUAGES_KEY } from "@/pages/project/editentry/ListTranslations";
Expand Down Expand Up @@ -59,6 +59,8 @@ export const EntryNodesTableBody = ({
}: Props) => {
const [shownLanguageCodes, setShownLanguageCodes] = useState<string[]>([]);

const navigate = useNavigate();

useEffect(() => {
// get shown languages from local storage if it exists else use main language
try {
Expand Down Expand Up @@ -95,8 +97,9 @@ export const EntryNodesTableBody = ({
<TableRow
key={id}
hover
component={Link}
to={`/${taxonomyName}/${branchName}/entry/${id}`}
onClick={() => {
navigate(`/${taxonomyName}/${branchName}/entry/${id}`);
}}
sx={{ textDecoration: "none" }}
>
<TableCell align="left" component="td" scope="row">
Expand Down
33 changes: 19 additions & 14 deletions taxonomy-editor-frontend/src/pages/project/errors/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ import {
TableBody,
TableHead,
TableContainer,
TableRow,
Stack,
} from "@mui/material";
import MaterialTable from "@material-table/core";
Expand Down Expand Up @@ -69,22 +70,26 @@ export const Errors = () => {
<TableContainer sx={{ mb: 2 }}>
<Table style={{ border: "solid", borderWidth: 1.5 }}>
<TableHead>
<TableCell align="left">
<Typography variant="h6">Taxonomy Name</Typography>
</TableCell>
<TableCell align="left">
<Typography variant="h6">Branch Name</Typography>
</TableCell>
<TableRow>
<TableCell align="left">
<Typography variant="h6">Taxonomy Name</Typography>
</TableCell>
<TableCell align="left">
<Typography variant="h6">Branch Name</Typography>
</TableCell>
</TableRow>
</TableHead>
<TableBody>
<TableCell align="left" component="td" scope="row">
<Typography variant="body1">
{toTitleCase(taxonomyName || "")}
</Typography>
</TableCell>
<TableCell align="left" component="td" scope="row">
<Typography variant="body1">{branchName}</Typography>
</TableCell>
<TableRow>
<TableCell align="left" component="td" scope="row">
<Typography variant="body1">
{toTitleCase(taxonomyName || "")}
</Typography>
</TableCell>
<TableCell align="left" component="td" scope="row">
<Typography variant="body1">{branchName}</Typography>
</TableCell>
</TableRow>
</TableBody>
</Table>
</TableContainer>
Expand Down
Loading