Fix iostream.h include; incorrect variable names #309
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`include <iostream.h>` is wrong, it's `include <iostream>` as used in the other parts. Variable names starting with an underscore followed by an uppercase letter are reserved for the implementation, same for variables containing two consecutive underscores. https://stackoverflow.com/questions/228783/what-are-the-rules-about-using-an-underscore-in-a-c-identifier Note that the `using namespace std;` is actually frowned upon, but as it's so wildly in use (and also the default on ideone) I didn't change that. Also there's some minor terminology mistakes but I doubt that the book benefits from fixing those.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
include <iostream.h>is wrong, it'sinclude <iostream>as used in the other parts.Variable names starting with an underscore followed by an uppercase letter are reserved for the implementation, same for variables containing two consecutive underscores.
https://stackoverflow.com/questions/228783/what-are-the-rules-about-using-an-underscore-in-a-c-identifier
Note that the
using namespace std;is actually frowned upon, but as it's so wildly in use (and also the default on ideone) I didn't change that. Also there's some minor terminology mistakes but I doubt that the book benefits from fixing those.