Skip to content

Commit 48e8215

Browse files
fixup! ✨(backend) add from_batch_order to order serializer admin API
1 parent 4f05283 commit 48e8215

File tree

2 files changed

+2
-16
lines changed

2 files changed

+2
-16
lines changed

src/backend/joanie/core/serializers/admin.py

Lines changed: 0 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -1304,7 +1304,6 @@ class AdminOrderSerializer(serializers.ModelSerializer):
13041304
payment_schedule = AdminOrderPaymentSerializer(many=True, read_only=True)
13051305
credit_card = AdminCreditCardSerializer(read_only=True)
13061306
has_waived_withdrawal_right = serializers.BooleanField(read_only=True)
1307-
from_batch_order = serializers.SerializerMethodField(read_only=True)
13081307

13091308
class Meta:
13101309
model = models.Order
@@ -1334,12 +1333,6 @@ def get_total_currency(self, *args, **kwargs) -> str:
13341333
"""Return the code of currency used by the instance"""
13351334
return settings.DEFAULT_CURRENCY
13361335

1337-
def get_from_batch_order(self, instance) -> bool:
1338-
"""
1339-
Return True if the order was created from a batch order, otherwise False.
1340-
"""
1341-
return instance.from_batch_order
1342-
13431336

13441337
class AdminOrderLightSerializer(serializers.ModelSerializer):
13451338
"""
@@ -1365,7 +1358,6 @@ class AdminOrderLightSerializer(serializers.ModelSerializer):
13651358
total_currency = serializers.SerializerMethodField(read_only=True)
13661359
discount = serializers.SerializerMethodField(read_only=True)
13671360
voucher = serializers.SerializerMethodField(read_only=True)
1368-
from_batch_order = serializers.SerializerMethodField(read_only=True)
13691361

13701362
class Meta:
13711363
model = models.Order
@@ -1419,12 +1411,6 @@ def get_voucher(self, instance) -> str | None:
14191411
return instance.voucher.code
14201412
return None
14211413

1422-
def get_from_batch_order(self, instance) -> bool:
1423-
"""
1424-
Return True if the order was created from a batch order, otherwise False.
1425-
"""
1426-
return instance.from_batch_order
1427-
14281414

14291415
class AdminOrderExportSerializer(serializers.ModelSerializer): # pylint: disable=too-many-public-methods
14301416
"""

src/backend/joanie/tests/swagger/admin-swagger.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8298,7 +8298,7 @@
82988298
},
82998299
"from_batch_order": {
83008300
"type": "boolean",
8301-
"description": "Return True if the order was created from a batch order, otherwise False.",
8301+
"description": "Returns boolean value whether the order is from a batch order",
83028302
"readOnly": true
83038303
}
83048304
},
@@ -8462,7 +8462,7 @@
84628462
},
84638463
"from_batch_order": {
84648464
"type": "boolean",
8465-
"description": "Return True if the order was created from a batch order, otherwise False.",
8465+
"description": "Returns boolean value whether the order is from a batch order",
84668466
"readOnly": true
84678467
}
84688468
},

0 commit comments

Comments
 (0)